Re: [PATCH] log: re-encode commit messages before grepping
- From
Jeff King <peff@peff.net>
- Date
- Feb 11, 2013, 21:14 UTC
- Message-ID
- <20130211211429.GE32740@sigill.intra.peff.net>
- In-Reply-To
- <7vmwvalfnn.fsf@alter.siamese.dyndns.org>
On Mon, Feb 11, 2013 at 01:11:24PM -0800, Junio C Hamano wrote:
Show 11 quoted lines
> Jeff King <peff@peff.net> writes: > > > 1. I suppose we could also use $LANG or one of the $LC_* variables to > > guess at the encoding of the user's pattern. But I think using the > > output encoding makes the most sense, since then the pattern you > > searched for will actually be in the output. > > I agree. In addition, if we were to do anything with LANG/LC_CTYPE, > it should be done at the layer that implements log-output-encoding > (e.g. lack of configured encoding with nonstandard LANG/LC_CTYPE > would use the locale, or something), I think.
Yeah, I had the same thought. I'll leave it to somebody who knows/cares more about i18n. In my world view, utf8 is good enough for everyone. :)
-Peff