Re: Segmentation fault with latest git (070c57df)

From: Jeff King <peff@peff.net>
Date: Feb 4, 2013, 08:37 UTC
Message-ID: <20130204083701.GA30835@sigill.intra.peff.net>
In-Reply-To: <7vehgw5z7n.fsf@alter.siamese.dyndns.org>

On Sun, Feb 03, 2013 at 11:13:00PM -0800, Junio C Hamano wrote:

Show 10 quoted lines

> Yeah, that result is understandable, as .depend/*.o.d files will not
> be rebuilt when the rules to build them changes in the Makefile.
> Applying the patch to the Makefile in the pristine old tree, run the
> build (which will generate .depend/*.o.d files with the corrected
> rules), then checking out the new tree and running the build again
> without "make clean", with or with the patch applied, would validate
> that the patch fixes the issue for old ccache.
> 
> Thanks Jonathan for diagnosing, fixing, and thanks Jongman for
> testing.

Do we want to do anything with the other dependency hole I found here:

  http://article.gmane.org/gmane.comp.version-control.git/215211

It's definitely a potential problem, but I don't think we have any reports of it happening in practice, so it might not be worth worrying about. Doing a clean version of the fix here:

  http://article.gmane.org/gmane.comp.version-control.git/215212

would probably involve reorganizing our .depend directory structure, unless somebody can cook up some clever use of make's patsubst.

-Peff