git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATH/RFC] Revert "compat: add strtok_r()"

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Feb 1, 2013, 20:49 UTC
Message-ID
<20130201204927.GG12368@google.com>
In-Reply-To
<1359714786-1912-1-git-send-email-kusmabite@gmail.com>
Hi Erik,
Erik Faye-Lund wrote:
Show 5 quoted lines
> This reverts commit 78457bc0ccc1af8b9eb776a0b17986ebd50442bc.
>
> commit 28c5d9e ("vcs-svn: drop string_pool") previously removed
> the only call-site for strtok_r. So let's get rid of the compat
> implementation as well.
Yes, good idea.  Sorry I didn't take care of this at the time.
> Conflicts:
> 	Makefile
> 	config.mak.in
> 	configure.ac

Since the conflicts were straightforward, I'd drop this or replace it with a quick description of any surprising choices made in resolving them.

Thanks.  With the fixup from your reply squashed in,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Previous: Erik Faye-LundNext: Junio C Hamano
Message 3 of 5 in “[PATH/RFC] Revert "compat: add strtok_r()"”
  1. Erik Faye-LundFeb 1, 2013
  2. Erik Faye-LundFeb 1, 2013
  3. Jonathan NiederFeb 1, 2013
  4. Junio C HamanoFeb 25, 2013
  5. Erik Faye-LundFeb 26, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.