Re: [PATCH 2/6] fixup! fixup! fixup! Change 'git' to 'Git' whenever the whole system is referred to #1

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Feb 1, 2013, 19:43 UTC
Message-ID: <20130201194308.GC12368@google.com>
In-Reply-To: <242116275.1090080.1359742076320.JavaMail.ngmail@webmail18.arcor-online.net>

Hi,

Thomas Ackermann wrote:

Show 22 quoted lines

> Found by Junio:
> Change git-dir to $GIT_DIR and git-file to gitfile.
>
> Signed-off-by: Thomas Ackermann <th.acker@arcor.de>
> ---
>  Documentation/git-rev-parse.txt | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/git-rev-parse.txt b/Documentation/git-rev-parse.txt
> index c743469..14386ed 100644
> --- a/Documentation/git-rev-parse.txt
> +++ b/Documentation/git-rev-parse.txt
> @@ -187,9 +187,9 @@ print a message to stderr and exit with nonzero status.
>  	Flags and parameters to be parsed.
>  
>  --resolve-git-dir <path>::
> -	Check if <path> is a valid git-dir or a git-file pointing to a valid
> -	git-dir. If <path> is a valid git-dir the resolved path to git-dir will
> -	be printed.
> +	Check if <path> is a valid `$GIT_DIR` or a gitfile pointing to a valid
> +	`$GIT_DIR`. If <path> is a valid `$GIT_DIR` the resolved path to `$GIT_DIR`
> +	will be printed.

Hm, I don't find the old or the new version very easy to understand. Perhaps the idea is something like this?

	Check if <path> is a valid git repository (.git or <project>.git
	directory) or "gitdir:" file.  If <path> is a "gitdir:" file
	then the resolved path to the corresponding real git repository
	will be printed.

Thanks, Jonathan