Re: [PATCH] Rename {git- => git}remote-helpers.txt

From: John Keeping <john@keeping.me.uk>
Date: Jan 31, 2013, 22:28 UTC
Message-ID: <20130131222817.GP1342@serenity.lan>
In-Reply-To: <7vy5f9dmrt.fsf@alter.siamese.dyndns.org>

On Thu, Jan 31, 2013 at 02:13:10PM -0800, Junio C Hamano wrote:

Show 24 quoted lines

> John Keeping <john@keeping.me.uk> writes:
> 
> > When looking up a topic via "git help <topic>", git-help prepends "git-"
> > to topics that are the names of commands (either builtin or found on the
> > path) and "git" (no hyphen) to any other topic name.
> >
> > "git-remote-helpers" is not the name of a command, so "git help
> > remote-helpers" looks for "gitremote-helpers" and does not find it.
> >
> > Fix this by renaming "git-remote-helpers.txt" to
> > "gitremote-helpers.txt".
> >
> > Signed-off-by: John Keeping <john@keeping.me.uk>
> >
> > ---
> > Changes since v1:
> >
> > - add gitremote-helpers.txt to the Makefile since it is no longer caught
> >   by git-*.txt.
> >
> > - add a simple git-remote-helpers.html to help people following links to
> >   the old name.
> 
> Doesn't "make clean" remove the placeholder file?

Yes. Should I change it to "git-remote-helpers.html.in" and then copy it into place? That seems like the simplest answer and means that "*.html" will continue to refer only to generated files.

John