git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[GUILT] [PATCH 7/7] Drop unneeded git version check.

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Jan 16, 2013, 02:31 UTC
Message-ID
<20130116023144.GP12524@google.com>
In-Reply-To
<20130116022606.GI12524@google.com>

Git's compatibility record is pretty good, so there's no need to worry that newer versions of git will break the "git config" command.

Without this change, guilt errors out for git 1.8. With it, all tests pass.

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
Thanks for reading.
 guilt | 11 -----------
 1 file changed, 11 deletions(-)
diff --git a/guilt b/guilt
index 66a671a..6cb43e3 100755
--- a/guilt
+++ b/guilt
@@ -26,17 +26,6 @@ SUBDIRECTORY_OK=1
 . "$(git --exec-path)/git-sh-setup"
 
 #
-# Git version check
-#
-gitver=`git --version | cut -d' ' -f3 | sed -e 's/^debian\.//'`
-case "$gitver" in
-	1.5.*)	;; # git config
-	1.6.*)	;; # git config
-	1.7.*)	;; # git config
-	*)	die "Unsupported version of git ($gitver)" ;;
-esac
-
-#
 # Shell library
 #
 usage()
-- 
1.8.1
Previous: Jonathan NiederNext: Theodore Ts'o
Message 8 of 13 in “guilt patches, including git 1.8 support”
  1. 0/7 guilt patches, including git 1.8 supportJonathan Nieder, Jan 16, 2013
  2. [GUILT] [PATCH 1/7] get rid of "cat: write error: Broken pipe" error messageJonathan Nieder, Jan 16, 2013
  3. [GUILT] [PATCH 2/7] The tests should not fail if log.date or log.decorate are set.Jonathan Nieder, Jan 16, 2013
  4. [GUILT] [PATCH 3/7] Testsuite: get rid of "Broken pipe" errors from yes.Jonathan Nieder, Jan 16, 2013
  5. [GUILT] [PATCH 4/7] Handle empty patches and patches with only a header.Jonathan Nieder, Jan 16, 2013
  6. [GUILT] [PATCH 5/7] Fix fatal "guilt graph" error in sha1sum invocation.Jonathan Nieder, Jan 16, 2013
  7. [GUILT] [PATCH 6/7] Change git branch when patches are applied.Jonathan Nieder, Jan 16, 2013
  8. [GUILT] [PATCH 7/7] Drop unneeded git version check.Jonathan Nieder, Jan 16, 2013
  9. Theodore Ts'oJan 16, 2013
  10. Josef 'Jeff' SipekJan 16, 2013
  11. Per CederqvistJan 20, 2013
  12. Josef 'Jeff' SipekJan 20, 2013
  13. Josef 'Jeff' SipekJan 27, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.