Re: [PATCH] attr: fix off-by-one directory component length calculation
- From
Jean-Noël AVILA <avila.jn@gmail.com>
- Date
- Jan 15, 2013, 19:53 UTC
- Message-ID
- <201301152053.58561.avila.jn@gmail.com>
- In-Reply-To
- <7vwqve2qk3.fsf@alter.siamese.dyndns.org>
Le mardi 15 janvier 2013 20:29:16, Junio C Hamano a écrit :
Show 14 quoted lines
> "Jean-Noël AVILA" <avila.jn@gmail.com> writes:
> > Thank you for the explanation.
> >
> > I did not monitor the system calls when writing that patch.
> > Where is the perf framework?
> >
> > As the mistake is located in the "find_basename" function, I would
> > propose a fix directly into it so that the output fits what the other
> > functions expect.
>
> Isn't that a crazy semantics for the function, though? I would
> expect find_basename("/a/path/to/file") to return "file", not
> "/file".
> Yes, it is. I was wrong on the meaning of basename.
Btw, the test 10 to t9902 is failing on my Debian testing. Is it a known issue?