git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-fast-import(1): remove duplicate "--done" option

From
John Keeping <john@keeping.me.uk>
Date
Jan 5, 2013, 16:06 UTC
Message-ID
<20130105160652.GE6440@serenity.lan>

The "--done" option to git-fast-import is documented twice in its manual page. Combine the best bits of each description, keeping the location of the instance that was added first.

Signed-off-by: John Keeping <john@keeping.me.uk>
---
I'm guessing that the reason the option was documented again (in commit
3266de10) is because the options are not in an obvious order.  There
does seem to be some grouping of the options by type, but without
subheadings I wonder if it would make more sense to just put them all in
alphabetical order?
 Documentation/git-fast-import.txt | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/Documentation/git-fast-import.txt b/Documentation/git-fast-import.txt
index 68bca1a..4ef5721 100644
--- a/Documentation/git-fast-import.txt
+++ b/Documentation/git-fast-import.txt
@@ -39,10 +39,6 @@ OPTIONS
 	See ``Date Formats'' below for details about which formats
 	are supported, and their syntax.
 
--- done::
-	Terminate with error if there is no 'done' command at the
-	end of the stream.
-
 --force::
 	Force updating modified existing branches, even if doing
 	so would cause commits to be lost (as the new commit does
@@ -108,7 +104,8 @@ OPTIONS
 	output.
 
 --done::
-	Require a `done` command at the end of the stream.
+	Terminate with error if there is no 'done' command at the
+	end of the stream.
 	This option might be useful for detecting errors that
 	cause the frontend to terminate before it has started to
 	write a stream.
-- 
1.8.0.2
Next: Eric S. Raymond
Message 1 of 5 in “git-fast-import(1): remove duplicate "--done" option”
  1. git-fast-import(1): remove duplicate "--done" optionJohn Keeping, Jan 5, 2013
  2. Eric S. RaymondJan 5, 2013
  3. Jonathan NiederJan 5, 2013
  4. git-fast-import(1): remove duplicate '--done' optionJohn Keeping, Jan 7, 2013
  5. git-fast-import(1): remove duplicate '--done' optionJohn Keeping, Jan 8, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.