Re: [PATCH v2 0/2] DEFAULT_DOC_TARGET

From: Jeff King <peff@peff.net>
Date: Jan 3, 2013, 20:37 UTC
Message-ID: <20130103203738.GA8269@sigill.intra.peff.net>
In-Reply-To: <20130103203222.GB4632@sigill.intra.peff.net>

On Thu, Jan 03, 2013 at 03:32:22PM -0500, Jeff King wrote:

Show 19 quoted lines

> On Thu, Jan 03, 2013 at 11:05:18AM -0800, Junio C Hamano wrote:
> 
> > This allows things like:
> > 
> >   $ DEFAULT_DOC_TARGET=html make doc
> >   $ DEFAULT_DOC_INSTALL_TARGET=html make install-doc
> > 
> > on a platform that does not have manpage viewer.  Which is not very
> > useful, given that you can already say
> > 
> >   $ make install-html
> > 
> > on such a platform, and these install-$format targets will not go
> > away.
> 
> I think the usefulness is that it can be set by default for a particular
> uname, so people on Windows can just type "make install-doc" without
> having to care about setting anything (though to be honest, I do not
> even know what they build by default; maybe they do build manpages).

I also notice that we have DEFAULT_HELP_FORMAT (which is "html" on Windows). Wouldn't that be a sane default for DEFAULT_DOC_TARGET if it is set? I guess we can set all three independently for maximum flexibility, though, but it seems like a sane fallback.

-Peff