git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH V2] t9810: Do not use sed -i

From
PWPete Wyckoff <pw@padd.com>
Date
Jan 3, 2013, 03:08 UTC
Message-ID
<20130103030811.GA30979@padd.com>
In-Reply-To
<7vhamz18y3.fsf@alter.siamese.dyndns.org>
gitster@pobox.com wrote on Wed, 02 Jan 2013 15:06 -0800:
Show 18 quoted lines
> Pete Wyckoff <pw@padd.com> writes:
> 
> > tboegi@web.de wrote on Wed, 02 Jan 2013 00:20 +0100:
> >> sed -i is not portable on all systems.
> >> Use sed with different input and output files.
> >> Utilize a tmp file whenever needed
> >> 
> >> Added missing && at 2 places
> >> 
> >> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
> >
> > One more teensy fix is needed in this hunk, following Junio's
> > comment about redirections going at the end:
> 
> I've already pushed out the previous one on 'pu' after fixing it up
> like this.
> 
> Thanks.  Anything I missed?

I should have guessed that you would just silently fix it. Thanks!

		-- Pete
Previous: Junio C Hamano
Message 4 of 4 in “t9810: Do not use sed -i”
  1. t9810: Do not use sed -iTorsten Bögershausen, Jan 1, 2013
  2. Pete WyckoffJan 2, 2013
  3. Junio C HamanoJan 2, 2013
  4. Pete WyckoffJan 3, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.