Re: [PATCH] gitk: add a checkbox to control the visibility of tags

From: Paul Mackerras <paulus@samba.org>
Date: Jan 2, 2013, 07:17 UTC
Message-ID: <20130102071701.GG20724@iris.ozlabs.ibm.com>
In-Reply-To: <7vlidhmc5i.fsf@alter.siamese.dyndns.org>

On Sat, Dec 01, 2012 at 06:16:25PM -0800, Junio C Hamano wrote:

Show 21 quoted lines

> Łukasz Stelmach <stlman@poczta.fm> writes:
> 
> > Enable hiding of tags displayed in the tree as yellow labels.
> > If a repository is used together with a system like Gerrit
> > there may be quite a lot of tags used to control building
> > and there may be hardly any place left for commit subjects.
> >
> > Signed-off-by: Łukasz Stelmach <stlman@poczta.fm>
> > ---
> 
> Paul, this patch is not done against your tree (does not have gitk
> at the top-level), but other than that, the change mimics the way
> existing hideremoes is implemented and looks reasonable to me.
> 
> We _may_ want to unify these two "hidestuff" into a list of patterns
> that hides any ref that match one of the patterns in the list, e.g.
> 
> 	set hidestuff {refs/heads/*/* refs/tags/* refs/remotes/*}
> 
> may hide all tags, all remote-tracking branches and local branches
> that have a slash in their names.

If the concern is the amount of screen real-estate that the tags take up when there are many of them (which is a reasonable concern), I'd rather just put a single tag icon with "tags..." inside it and arrange to list all the tags in the diff display pane when the user clicks on it. I think that would be better than not showing the tags at all.

Paul.