Re: [PATCH] gitk: Replaced "green" with "#00FF00".

From: Paul Mackerras <paulus@samba.org>
Date: Dec 31, 2012, 23:21 UTC
Message-ID: <20121231232159.GA20724@iris.ozlabs.ibm.com>
In-Reply-To: <7v623nmmly.fsf@alter.siamese.dyndns.org>

On Thu, Dec 27, 2012 at 09:27:37AM -0800, Junio C Hamano wrote:

Show 12 quoted lines

> Peter Hofmann <git-dev@uninformativ.de> writes:
> 
> > Subject: Re: [PATCH] gitk: Replaced "green" with "#00FF00".
> 
> > gitk looks pretty awkward with Tk 8.6. "green" is simply too dark now
> > because it has changed from "#00FF00" to "#008000".
> 
> Your observation "awkward" is somewhat subjective and I am hesitant
> to recommend this change without a better justification.  Given the
> reasoning behind the change Tcl/Tk people made, I wouldn't be
> surprised if people coming from webapp world view the "green" color
> rendered by updated Tcl/Tk more natural.

Given that "green" is used as the background color in some places, e.g. for the boxes containing the names of heads, and that the general scheme is dark foreground on light background, I agree that #008000 is too dark in those places.

> Besides, if we are declaring with this patch that we will stick to
> X11 colors and will not adopt W3C colors, the patch shouldn't update
> only "green", but set all the other colors in stone, no?  "purple",
> for example, is also different between X11 and W3C.

Purple is only used for octopus merges. I'd like to think of a better way to use color in representing octopus merges if possible.

> > One could also use "lime" instead of "#00FF00" but that would break
> > compatibility with older versions of Tk.
> 
> A better solution might be to make these colors customizable.

Indeed. Some people prefer to have all their windows to have light foregrounds on dark backgrounds, so they would also benefit from having more of the colors customizable.

Paul.