git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH] gitk: Visualize a merge commit with a right-click in gitk

From
JHJason Holden <jason.k.holden.swdev@gmail.com>
Date
Dec 31, 2012, 18:46 UTC
Message-ID
<20121231184611.GB8665@gmail.com>
In-Reply-To
<20121231042736.GA14921@iris.ozlabs.ibm.com>
On Mon, Dec 31, 2012 at 03:27:36PM +1100, Paul Mackerras wrote:
Show 6 quoted lines
> 
> Thanks for the patch.  I have a couple of comments about it.  First,
> the exec command waits for the process to complete, which means that
> the initial gitk GUI will be unresponsive until the user quits the
> gitk window showing the merge, which could be quite confusing for the
> user.

Good catch. Adding an ampersand on to the exec looks like it fixes the unresponsiveness. Any issues with that approach?

Show 5 quoted lines
> 
> Secondly, gitk already has support for showing multiple views of a
> repository, that is, different subsets of the commits.  Wouldn't it be
> much better to have your new menu item simply create a new view
> showing the merge, rather than creating a whole new window?

I've found when using this feature that I tend to use it in a stack-like fashion. I tend to want to "push" a merge-view onto the stack, investigate that view of history for a bit, then "pop" back to my old view. But you're correct that you can end up with a lot of windows pretty quick. Any support for stack-like views in the current gui that I missed?

I've got another feature brewing, similiar to the merge-view, where you can right-click on a file and a new window pops up with the history of just that file. I tend to use that feature in a stack-like fashion as well.

Maybe the seperate-window/new-view-in-same-window should be a new user preference?

Previous: Paul Mackerras
Message 3 of 3 in “gitk: Visualize a merge commit with a right-click in gitk”
  1. gitk: Visualize a merge commit with a right-click in gitkJason Holden, Dec 30, 2012
  2. Paul MackerrasDec 31, 2012
  3. Jason HoldenDec 31, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.