Re: [RFC] pack-objects: compression level for non-blobs
- From
Jeff King <peff@peff.net>
- Date
- Dec 29, 2012, 05:27 UTC
- Message-ID
- <20121229052747.GA14928@sigill.intra.peff.net>
- In-Reply-To
- <CACsJy8AN3y_4wcZ_w0zz+ZAaDasRT-+h8vA_fp2j4+FL00dbLw@mail.gmail.com>
On Sat, Dec 29, 2012 at 12:25:04PM +0700, Nguyen Thai Ngoc Duy wrote:
Show 6 quoted lines
> > But just dropping the compression (or doing partial > > decompression when we only care about the beginning part) is way less > > code and complexity. > > I think I tried the partial decompression for commit header and it did > not help much (or I misremember it, not so sure).
I'll see if I can dig up the reference, as it was something I was going to look at next.
> > There's no cache to manage. > > If reachability bitmap is implemented, we'll have per-pack cache > infrastructure ready, so less work there for commit cache.
True. I don't want to dissuade you from doing any commit cache work. I only wanted to point out that this alternative may have merit because of its simplicity (so we can use it until a caching solution exists, or even after, if managing the cache has downsides).
-Peff