Re: [PATCH] t0200: "locale" may not exist
- From
Jeff King <peff@peff.net>
- Date
- Dec 19, 2012, 15:32 UTC
- Message-ID
- <20121219153205.GA22207@sigill.intra.peff.net>
- In-Reply-To
- <7vd2y6awo7.fsf@alter.siamese.dyndns.org>
On Wed, Dec 19, 2012 at 07:28:24AM -0800, Junio C Hamano wrote:
Show 6 quoted lines
> > +test_expect_success GETTEXT,!GETTEXT_POISON 'setup locale' '
> > # is_IS.UTF-8 on Solaris and FreeBSD, is_IS.utf8 on Debian
> > - is_IS_locale=$(locale -a | sed -n '/^is_IS\.[uU][tT][fF]-*8$/{
> > + is_IS_locale=$(locale -a | sed -n "/^is_IS\.[uU][tT][fF]-*8\$/{
>
> Do we need to do this \$?I'm not sure. Sane shells leave "$/" untouched, but I do not know if we need to be conservative.
> > - say "# lib-gettext: Found '$is_IS_locale' as an is_IS UTF-8 locale" > > + say "# lib-gettext: Found \"$is_IS_locale\" as an is_IS UTF-8 locale" > > '\''?
Fine by me. I do not care either way in the output, and the escaped dq is marginally more readable in the source. But either way the source is pretty ugly. :)
-Peff