git/list[1] front-page[2] threads[3] people[4] search[5] about
 

$PATH pollution and t9902-completion.sh

From
Adam Spiers <git@adamspiers.org>
Date
Dec 17, 2012, 01:05 UTC
Message-ID
<20121217010538.GC3673@gmail.com>

t/t9902-completion.sh is currently failing for me because I happen to have a custom shell-script called git-check-email in ~/bin, which is on my $PATH. This is different to a similar-looking case reported recently, which was due to an unclean working tree:

  http://thread.gmane.org/gmane.comp.version-control.git/208085

It's not unthinkable that in the future other tests could break for similar reasons. Therefore it would be good to sanitize $PATH in the test framework so that it cannot destabilize tests, although I am struggling to think of a good way of doing this. Naively stripping directories under $HOME would not protect against git "plugins" such as the above being installed into places like /usr/bin. Thoughts?

Next: Jeff King
Message 1 of 10 in “$PATH pollution and t9902-completion.sh”
  1. Adam SpiersDec 17, 2012
  2. Jeff KingDec 20, 2012
  3. Adam SpiersDec 20, 2012
  4. Torsten BögershausenDec 20, 2012
  5. Junio C HamanoDec 20, 2012
  6. Junio C HamanoDec 20, 2012
  7. Jeff KingDec 20, 2012
  8. Torsten BögershausenDec 20, 2012
  9. Junio C HamanoDec 20, 2012
  10. Jeff KingDec 20, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.