[PATCH/RFCv2 0/2] compiling git with gcc -O3 -Wuninitialized

From: Jeff King <peff@peff.net>
Date: Dec 15, 2012, 17:36 UTC
Message-ID: <20121215173621.GA21011@sigill.intra.peff.net>
In-Reply-To: <20121215110930.GA23727@sigill.intra.peff.net>

On Sat, Dec 15, 2012 at 06:09:30AM -0500, Jeff King wrote:

Show 7 quoted lines

> > Does
> > 
> >   #define error(fmt, ...) (error_impl(fmt, __VA_ARGS__), -1)
> > 
> > cause problems when not used in a return statement?
> 
> Thanks, that was the cleverness I was missing.

Here it is as patches. One problem with this method is that if the function implementation ever changes to _not_ return -1, then we get no warning that our macro and the function implementation have diverged in meaning.

  [1/2]: make error()'s constant return value more visible
  [2/2]: silence some -Wuninitialized false positives

These would go on top of 1/3 from the original series to make -Wall -O3 clean (I'll repost the series as a whole when it is more obvious what we want to do).

-Peff