Re: [PATCH] status: respect advice.statusHints for ahead/behind advice

From: Jeff King <peff@peff.net>
Date: Dec 3, 2012, 18:32 UTC
Message-ID: <20121203183243.GA25526@sigill.intra.peff.net>
In-Reply-To: <7vr4n7rrgb.fsf@alter.siamese.dyndns.org>

On Mon, Dec 03, 2012 at 09:11:32AM -0800, Junio C Hamano wrote:

Show 17 quoted lines

> > On top of mm/status-push-pull-advise.
> >
> > I left "git checkout" alone, though I'd also like to turn it off there,
> > too. Should it get a separate advice option there? Should it simply
> > respect statusHints (it seems odd because I know that "status" there
> > means "git status", not "hints about the status of your repo")?
> 
> I agree that we should have a toggle to turn it off and I think it
> is OK to reuse the same "hints about the status" option for this
> purpose.  It is not like there is a released version that already
> gives the advice (possibly with some other option to turn it off)
> and you are changing the behaviour of "checkout" by suddenly making
> it honor statusHints advice.
> 
> So let's do a lot simpler patch instead.
> 
> -- >8 --

Perfect, thanks.

-Peff