git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] ignore SIG{INT,QUIT} when launching editor

From
KMKrzysztof Mazur <krzysiek@podlesie.net>
Date
Dec 1, 2012, 12:34 UTC
Message-ID
<20121201123437.GA10287@shrek.podlesie.net>
In-Reply-To
<20121130223943.GA27120@sigill.intra.peff.net>
On Fri, Nov 30, 2012 at 05:39:43PM -0500, Jeff King wrote:
Show 8 quoted lines
> This is a re-roll of the pf/editor-ignore-sigint series.
> 
> People mentioned some buggy editors which go into an infinite EIO loop
> when their parent dies due to SIGQUIT. That should be a non-issue now,
> as we will be ignoring SIGQUIT. And even if you could replicate it
> (e.g., with another signal) those programs should be (and reportedly
> have been) fixed. It is not git's job to babysit its child processes.
>

Also some good editors printed error message after they got EIO, confusing the user.

Looks good to me. I've tested this with ed (always ignores SIGINT and SIGQUIT), vim (always ignores SIGINT, but dies after three SIGQUIT) and "sleep" (dies after SIGINT and SIGQUIT) and git works now as expected. Doing what editor does is probably the best thing to do. 

Tested-by: Krzysztof Mazur <krzysiek@podlesie.net>
Thanks,
Krzysiek
Previous: Jeff KingNext: Paul Fox
Message 7 of 9 in “ignore SIG{INT,QUIT} when launching editor”
  1. 0/5 ignore SIG{INT,QUIT} when launching editorJeff King, Nov 30, 2012
  2. 1/5 run-command: drop silent_exec_failure arg from wait_or_whineJeff King, Nov 30, 2012
  3. 2/5 launch_editor: refactor to use start/finish_commandJeff King, Nov 30, 2012
  4. 3/5 launch_editor: ignore terminal signals while editor has controlJeff King, Nov 30, 2012
  5. 4/5 run-command: do not warn about child death from terminalJeff King, Nov 30, 2012
  6. 5/5 launch_editor: propagate signals from editor to gitJeff King, Nov 30, 2012
  7. Krzysztof MazurDec 1, 2012
  8. Paul FoxDec 1, 2012
  9. Junio C HamanoDec 2, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.