Re: [PATCH 1/2] git-fast-import.txt: improve documentation for quoted paths

From: Jeff King <peff@peff.net>
Date: Nov 29, 2012, 19:19 UTC
Message-ID: <20121129191926.GA21439@sigill.intra.peff.net>
In-Reply-To: <7vvccop6dv.fsf@alter.siamese.dyndns.org>

On Thu, Nov 29, 2012 at 11:15:56AM -0800, Junio C Hamano wrote:

Show 8 quoted lines

> >> -If an `LF` or double quote must be encoded into `<path>` shell-style
> >> -quoting should be used, e.g. `"path/with\n and \" in it"`.
> >> +If an `LF`, backslash or double quote must be encoded into `<path>`
> >> +shell-style quoting should be used, and the complete name should be
> >> +surrounded with double quotes e.g. `"path/with\n, \\ and \" in it"`.
> 
> That "shell-style" contradicts with what fast-import.c says, though.
> It claims to grok \octal and described as C-style.

Yeah, I think it was just laziness by the original author to use "shell-style" to mean "quotes and backslash escaping" without thinking too hard about which escape sequences are available. Saying C-style is more accurate (and Matthieu's more recent update does that).

-Peff