git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Topics currently in the Stalled category

From
Jeff King <peff@peff.net>
Date
Nov 28, 2012, 03:22 UTC
Message-ID
<20121128032245.GD27772@sigill.intra.peff.net>
In-Reply-To
<CAMP44s3ZtCNsedJtsHDJx5d4Myjbbp+D6yT-rO-CmKOTtt91VQ@mail.gmail.com>
On Wed, Nov 28, 2012 at 04:15:12AM +0100, Felipe Contreras wrote:
Show 10 quoted lines
> > We could improve the test in t5801, but it is nice to let people on such
> > systems test it, as well. And the infrastructure might be useful if we
> > ever acquire more bash scripts.
> >
> > There's a fair bit of boilerplate, but I think this squashable patch
> > would do it:
> 
> Yeah, but I wonder what's the point of installing this script, it's
> mostly for testing and reference, and to add a whole category for that
> seems like overkill.

There's no point in installing it; I just didn't make the effort to avoid doing so (note that testpy and testsvn are also installed, which are in the same boat; it might make sense to split them all out like we do for $TEST_PROGRAMS).

I agree it's an annoying amount of boilerplate, but it seems simpler cognitively to me for it to behave as the other SCRIPT_* builds than to do something simple but inconsistent.

I do not care enough to argue about it. We need to do something to fix the impending test breakage on systems like Solaris. I have posted the patch to handle BASH_PATH, so do what you want.

-Peff
Previous: Felipe ContrerasNext: Felipe Contreras
Message 12 of 15 in “What's cooking in git.git (Nov 2012, #06; Mon, 19)”
  1. Junio C HamanoNov 19, 2012
  2. Felipe ContrerasNov 20, 2012
  3. Paul FoxNov 20, 2012
  4. Junio C HamanoNov 20, 2012
  5. Topics currently in the Stalled categoryJunio C Hamano, Nov 21, 2012
  6. Felipe ContrerasNov 21, 2012
  7. Jeff KingNov 28, 2012
  8. Felipe ContrerasNov 28, 2012
  9. Jeff KingNov 28, 2012
  10. Jeff KingNov 28, 2012
  11. Felipe ContrerasNov 28, 2012
  12. Jeff KingNov 28, 2012
  13. Felipe ContrerasNov 28, 2012
  14. Marc BranchaudNov 21, 2012
  15. Adam SpiersDec 1, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.