Re: [PATCH] Add documentation on how to integrate commands.

From: Eric S. Raymond <esr@thyrsus.com>
Date: Nov 26, 2012, 05:25 UTC
Message-ID: <20121126052500.GA15605@thyrsus.com>
In-Reply-To: <7vy5hpvukk.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com>:

Show 5 quoted lines

> As the first sentence in this paragraph does not make it clear
> enough that you are defining a new term "git execution directory",
> "execution directory" here may be misleading and can easily be
> mistaken as if we look something in the directory where the user
> runs "git" in.  We usually call it "exec path".

Fixed.

> Actually, we tend to avoid Python dependency for anything important
> and allow it only on fringes; people who lack Python environment are
> not missing much, and we would want to keep it that way until the
> situation on the Windows front changes.

Added:

    Python is fine for import utilities, surgical tools, remote helpers
    and other code at the edges of the git suite - but it should not yet
    be used for core functions. This may change in the future; the problem
    is that we need better Python integration in the git Windows installer
    before we can be confident people in that environment won't
    experience an unacceptably large loss of capability.

I will also take this as a part-resolution of the related policy thread. Issue perhaps to be revisited when the Windows port gets the Python support to a good state.

I will submit for separate consideration a patch proposing the following new guidelines:

1. Python code SHOULD NOT require an interpreter version newer than 2.6.

2. Python code SHOULD check the interpreter version and exit gracefully
   with an explanation if it detects that its dependency cannot be satisfied.

> I would prefer to see this sentence not call libgit.a a "library".
> We primarily use libgit.a to let linker pick necessary object files
> without us having to list object files for non-builtin command
> implementations and it is not designed to be used by other people.

Fixed.  I now refer to it as a "collection of functions".

> And when sending a patch in, do not forget to sign off your patches
> ;-)

Added.  I will submit a third time with a signoff. :-)

-- 
		<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>