Re: Topics currently in the Stalled category

From: Jeff King <peff@peff.net>
Date: Nov 21, 2012, 19:34 UTC
Message-ID: <20121121193401.GC16280@sigill.intra.peff.net>
In-Reply-To: <20121121092750.GA8262@shrek.podlesie.net>

On Wed, Nov 21, 2012 at 10:27:50AM +0100, Krzysztof Mazur wrote:

Show 23 quoted lines

> >  > * pf/editor-ignore-sigint (2012-11-11) 5 commits
> >  > 
> >  >  Avoid confusing cases where the user hits Ctrl-C while in the editor
> >  >  session, not realizing git will receive the signal. Since most editors
> >  >  will take over the terminal and will block SIGINT, this is not likely
> >  >  to confuse anyone.
> >  > 
> >  >  Some people raised issues with emacsclient, which are addressed by this
> >  >  re-roll. It should probably also handle SIGQUIT, and there were a
> >  >  handful of other review comments.
> >  > 
> >  >  Anybody interested in moving this forward?
> > 
> > i started this, but then jeff took it and ran with it and made it
> > right.  i think the remaining changes are small -- if jeff would
> > prefer, i can probably finish it.  (but i won't guarantee not to
> > mess up the "From:" lines.  :-)
> > 
> 
> I'm also interested. I sometimes use ":r !command" in vim, so far I never
> needed to use Ctrl-C, but maybe in future.
> 
> The SIGINT part seems to be finished, we need to decide what about SIGQUIT.

My plan was to just add in SIGQUIT[1] alongside SIGINT (and I think there may have been one or two other minor comments in response to the series). I am on vacation this week, but can revisit it next week. If somebody wants to re-roll it in the meantime, that would be fine with me.

-Peff

[1] Given the core-dumping behavior of SIGQUIT, I suspect it is not
    nearly as widely used as SIGINT, but it sounds more like the
    principle of least surprise to treat them the same.