Re: Re* [PATCH] gitweb: make remote_heads config setting work.

From: Jeff King <peff@peff.net>
Date: Nov 21, 2012, 19:31 UTC
Message-ID: <20121121193115.GB16280@sigill.intra.peff.net>
In-Reply-To: <7vpq37rk3v.fsf_-_@alter.siamese.dyndns.org>

On Tue, Nov 20, 2012 at 02:21:40PM -0800, Junio C Hamano wrote:

Show 13 quoted lines

> > Good catch. I think the "return" in the existing code suffers from the
> > same problem: it will bail on non-word characters in the $mi part, but
> > that part should allow arbitrary characters.
> 
> I am tired of keeping the "expecting reroll" entries and having to
> worry about them, so let's do this
> 
> -- >8 --
> Subject: [squash] gitweb: make remote_heads config setting work
> 
> Only the top-level and bottom-level names are case insensitive and
> spelled without "_".  Protect future support of subsection names
> from name mangling.

I think the end result is fine, though you are really fixing a bug here (the /\W/ check is moved up), and then also putting the remote_heads fix (s/_//g) into the right place. IOW, if you are going to squash, you should probably note the bug-fix part in the commit message explicitly.

-Peff