Re: [PATCH v2 1/6] completion: add comment for test_completion()

From: SZEDER Gábor <szeder@ira.uka.de>
Date: Nov 16, 2012, 20:54 UTC
Message-ID: <20121116205457.GY12052@goldbirke>
In-Reply-To: <1352644558-9410-2-git-send-email-felipe.contreras@gmail.com>

On Sun, Nov 11, 2012 at 03:35:53PM +0100, Felipe Contreras wrote:

Show 22 quoted lines

> So that it's easier to understand what it does.
> 
> Also, make sure we pass only the first argument for completion.
> Shouldn't cause any functional changes because run_completion only
> checks $1.
> 
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>  t/t9902-completion.sh | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh
> index cbd0fb6..5c06709 100755
> --- a/t/t9902-completion.sh
> +++ b/t/t9902-completion.sh
> @@ -54,10 +54,14 @@ run_completion ()
>  	__git_wrap__git_main && print_comp
>  }
>  
> +# Test high-level completion
> +# Arguments are:
> +# 1: typed text so far (cur)

Bash manuals calls this the current command line or words in the current command line. I'm not sure what you mean with '(cur)' here. The variable $cur in the completion script (or in bash-completion in general) is something completely different.

Show 11 quoted lines

> +# 2: expected completion
>  test_completion ()
>  {
>  	test $# -gt 1 && echo "$2" > expected
> -	run_completion "$@" &&
> +	run_completion "$1" &&
>  	test_cmp expected out
>  }
>  
> -- 
> 1.8.0