Re: [PATCH] gitweb: git_summary - show $project in title
- From
Jeff King <peff@peff.net>
- Date
- Nov 12, 2012, 23:25 UTC
- Message-ID
- <20121112232513.GF10531@sigill.intra.peff.net>
- In-Reply-To
- <1352611258-11450-1-git-send-email-xypron.glpk@gmx.de>
On Sun, Nov 11, 2012 at 06:20:58AM +0100, Henrich Schuchardt wrote:
Show 22 quoted lines
> Gitweb pages are structured by divs of class title with grey background.
> The shortlog, and the log page show the project name as the first title.
> Page summary only shows an empty grey box above the project details.
> This provides an inconstent user experience.
>
> This patch adds the missing project title.
>
> Signed-off-by: Henrich Schuchardt <xypron.glpk@gmx.de>
> ---
> gitweb/gitweb.perl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 10ed9e5..3e1c452 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -6451,7 +6451,7 @@ sub git_summary {
> git_header_html();
> git_print_page_nav('summary','', $head);
>
> - print "<div class=\"title\"> </div>\n";
> + print "<div class=\"title\">$project</div>\n";I do not have any opinion on whether the intent of the change is good or not, but shouldn't $project be run through esc_html() here?
-Peff