Re: [PATCH] Update cygwin.c for new mingw-64 win32 api headers

From: Jeff King <peff@peff.net>
Date: Nov 12, 2012, 21:43 UTC
Message-ID: <20121112214352.GB10531@sigill.intra.peff.net>
In-Reply-To: <CAK2bgnXLnKmnVwzE5U_1qZueUdj-QaT23f-iFmhJyRto3tWnhA@mail.gmail.com>

On Mon, Nov 12, 2012 at 04:39:39PM -0500, Mark Levedahl wrote:

Show 21 quoted lines

> >> diff --git a/Makefile b/Makefile
> >> index f69979e..1cc5d96 100644
> >> --- a/Makefile
> >> +++ b/Makefile
> >> @@ -1082,6 +1082,7 @@ ifeq ($(uname_O),Cygwin)
> >>               NO_SYMLINK_HEAD = YesPlease
> >>               NO_IPV6 = YesPlease
> >>               OLD_ICONV = UnfortunatelyYes
> >> +             V15_MINGW_HEADERS = YesPlease
> >>       endif
> >
> > The "if" part of the conditional that did not make it into the context
> > above is an expr match for "1.6.*" From the name, I would think that we
> > would want to use these headers on cygwin 1.5.* , too. Is v1.5 too old
> > to care about now?
> 
> The opening if expression is:
>     ifeq ($(shell expr "$(uname_R)" : '1\.[1-6]\.'),4)
> which I believe matches any version below 1.7. 1.5 is what is released
> opensource, 1.6 is (or was) available as a supported product from
> redhat. So, I think the stanza is ok as is.

Oh, right, I'm an idiot. I read the patch, thought "gee, I wonder what that conditional just outside the context is", looked it up, then promptly misremembered exactly what it said when writing the rest of my email.

Yes, what you have is absolutely right. Sorry for the noise.

-Peff