Re: [PATCH v2 1/5] push: return reject reasons via a mask
- From
Jeff King <peff@peff.net>
- Date
- Nov 9, 2012, 18:35 UTC
- Message-ID
- <20121109183535.GA22164@sigill.intra.peff.net>
- In-Reply-To
- <1352084908-32333-2-git-send-email-chris@rorvick.com>
On Sun, Nov 04, 2012 at 09:08:24PM -0600, Chris Rorvick wrote:
Show 7 quoted lines
> Pass all rejection reasons back from transport_push(). The logic is > simpler and more flexible with regard to providing useful feedback. > [...] > > void transport_print_push_status(const char *dest, struct ref *refs, > - int verbose, int porcelain, int *nonfastforward); > + int verbose, int porcelain, unsigned int *reject_mask);
You missed updating one call-site of this function in builtin/send-pack.c (gcc -Wall will now complain of the signed/unsigned mismatch in the passed-in pointer).
-Peff