git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/3] Introduce diff.submodule

From
Jeff King <peff@peff.net>
Date
Nov 8, 2012, 20:43 UTC
Message-ID
<20121108204312.GA8376@sigill.intra.peff.net>
In-Reply-To
<CALkWK0kdMbiTUYcSmY1OZOt6fjLTesi9y3S2LZvagjhu-0fn4g@mail.gmail.com>
On Sun, Nov 04, 2012 at 11:28:17PM +0530, Ramkumar Ramachandra wrote:
Show 12 quoted lines
> Jens Lehmann wrote:
> > Am 01.11.2012 11:43, schrieb Ramkumar Ramachandra:
> >> Hi,
> >>
> >> v1 is here:
> >> http://mid.gmane.org/1349196670-2844-1-git-send-email-artagnon@gmail.com
> >>
> >> I've fixed the issues pointed out in the review by Jens.
> >
> > Thanks, looking good to me.
> 
> Peff, can we pick this up?

Thanks for prodding, I missed the original. I have a few comments, but I'll respond directly.

Also, I was coincidentally looking at the same code today. You might find this interesting:

  http://article.gmane.org/gmane.comp.version-control.git/209188
-Peff
Previous: Ramkumar Ramachandra
Message 10 of 10 in “Introduce diff.submodule”
  1. 0/3 Introduce diff.submoduleRamkumar Ramachandra, Nov 1, 2012
  2. 1/3 Documentation: move diff.wordRegex from config.txt to diff-config.txtRamkumar Ramachandra, Nov 1, 2012
  3. 2/3 diff: introduce diff.submodule configuration variableRamkumar Ramachandra, Nov 1, 2012
  4. Jeff KingNov 8, 2012
  5. Ramkumar RamachandraNov 11, 2012
  6. Jeff KingNov 11, 2012
  7. 3/3 submodule: display summary header in boldRamkumar Ramachandra, Nov 1, 2012
  8. Jens LehmannNov 1, 2012
  9. Ramkumar RamachandraNov 4, 2012
  10. Jeff KingNov 8, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.