Re: [PATCH 0/2] Another minor cleanup involving string_lists

From: Jeff King <peff@peff.net>
Date: Nov 8, 2012, 17:38 UTC
Message-ID: <20121108173835.GH15560@sigill.intra.peff.net>
In-Reply-To: <1352104883-21053-1-git-send-email-mhagger@alum.mit.edu>

On Mon, Nov 05, 2012 at 09:41:21AM +0100, Michael Haggerty wrote:

Show 6 quoted lines

> Nothing really earthshattering here.  But it's funny how every time I
> look closely at a site where I think string_lists could be used, I
> find problems with the old code.  In this case is_absolute_path() is
> called with an argument that is not a null-terminated string, which is
> incorrect (though harmless because the function only looks at the
> first two bytes of the string).

Thanks, the new version is much easier on the eyes.

Show 6 quoted lines

> Another peculiarity of the (old and new) code is that it rejects
> "comments" even in paths taken from the colon-separated environment
> variable GIT_ALTERNATE_OBJECT_DIRECTORIES.  The fix would be to change
> link_alt_odb_entries() to take a string_list and let the callers strip
> out comments when appropriate.  But it didn't seem worth the extra
> code.

I don't think it's worth worrying about. Given that the entries must be absolute paths anyway, we do not even have to worry about an insane path starting with "#".

-Peff