Re: [PATCH/RFC] launch_editor: ignore SIGINT while the editor has control

From: Jeff King <peff@peff.net>
Date: Nov 8, 2012, 15:33 UTC
Message-ID: <20121108153331.GC15560@sigill.intra.peff.net>
In-Reply-To: <20121107233515.107ED2E8089@grass.foxharp.boston.ma.us>

On Wed, Nov 07, 2012 at 06:35:15PM -0500, Paul Fox wrote:

Show 6 quoted lines

> the user's editor likely catches SIGINT (ctrl-C).  but if the user
> spawns a command from the editor and uses ctrl-C to kill that command,
> the SIGINT will likely also kill git itself.  (depending on the
> editor, this can leave the terminal in an unusable state.)
> 
> Signed-off-by: Paul Fox <pgf@foxharp.boston.ma.us>

Thanks, I think this makes sense.

Show 9 quoted lines

> krzysztof wrote:
> ...
>  > editor.c: In function 'launch_editor':
>  > editor.c:42:3: warning: implicit declaration of function 'sigchain_push' [-Wimplicit-function-declaration]
>  > editor.c:44:3: warning: implicit declaration of function 'sigchain_pop' [-Wimplicit-function-declaration]
> 
> sigh.  i had that initially, lost the patch, and then recreated
> without it.  but i'm surprised my build (i did rebuild! :-) doesn't
> emit those errors.  in any case, here's the fixed patch.

gcc will not warn about implicit declarations by default; try compiling with "-Wall".

-Peff