Re: [PATCH] gitweb.perl: fix %highlight_ext mappings

From: rh <richard_hubbe11@lavabit.com>
Date: Nov 8, 2012, 18:36 UTC
Message-ID: <20121108103620.eb716adb2d7542c606c8b87a@lavabit.com>
In-Reply-To: <20121108180157.GK15560@sigill.intra.peff.net>

On Thu, 8 Nov 2012 13:01:57 -0500 Jeff King <peff@peff.net> wrote:

Show 18 quoted lines

> On Sun, Nov 04, 2012 at 09:45:55AM -0800, rh wrote:
> 
> > The previous change created a dictionary of one-to-one elements when
> > the intent was to map mutliple related types to one main type.
> > e.g. bash, ksh, zsh, sh all map to sh since they share similar
> > syntax This makes the mapping as the original change intended.
> > 
> > Signed-off-by: Richard Hubbell <richard_hubbe11@lavabit.com>
> 
> Thanks.
> 
> > diff --git a/gitweb.cgi.orig b/gitweb.cgi
> > index 060db27..155b238 100755
> > --- a/gitweb.cgi.orig
> > +++ b/gitweb.cgi
> 
> This is not the name of the source file in git.git, so "git am"
> choked. I was able to fix it up locally, though. No need to resend.

Somehow I knew that it wouldn't be a slam dunk! Thanks for doing what you do. FWIW maybe others can follow this thread to know what not to do. And save you extra work.

> 
> -Peff

-- "Now, in his heart, Ahab had some glimpse of this, namely; all my means are sane, my motive and my object mad."