Re: [PATCH] gitweb.perl: fix %highlight_ext mappings

From: Jeff King <peff@peff.net>
Date: Nov 4, 2012, 13:48 UTC
Message-ID: <20121104134841.GC31623@sigill.intra.peff.net>
In-Reply-To: <20121102141226.643a96e61b8bf383428c5287@lavabit.com>

On Fri, Nov 02, 2012 at 02:12:26PM -0700, rh wrote:

Show 11 quoted lines

> The previous change created a dictionary of one-to-one elements when
> the intent was to map mutliple related types to one main type.
> e.g. bash, ksh, zsh, sh all map to sh since they share similar syntax
> This makes the mapping as the original change intended.
> 
> Signed-off-by: rh <richard_hubbe11@lavabit.com>
> 
> diff --git a/gitweb.cgi.orig b/gitweb.cgi
> index 060db27..155b238 100755
> --- a/gitweb.cgi.orig
> +++ b/gitweb.cgi

Close on the format. There should be a "---" after the sign-off but before the diff. I can fix it up locally (and the patch looks good to me).

However, one final thing: the point of the sign-off is to indicate that you are legally OK to release the code under the DCO. For that reason, we usually require a real name (not rh). I can guess at your real name from your email, but I'd rather be sure. Can you provide it?

-Peff