Re: [PATCH 0/7] Move code from builtin to libgit.a

From: Jeff King <peff@peff.net>
Date: Oct 29, 2012, 07:43 UTC
Message-ID: <20121029074352.GF5102@sigill.intra.peff.net>
In-Reply-To: <1351266835-22610-1-git-send-email-pclouds@gmail.com>

On Fri, Oct 26, 2012 at 10:53:48PM +0700, Nguyen Thai Ngoc Duy wrote:

Show 14 quoted lines

> These two are big code moves, basically all {fetch,send}-pack code.
> While I think this is good cleanup (I get surprise every time I look
> at transport.c and it leads to buitin/fetch-pack.c), this is probably
> not a good idea if we have on flight topics, which may cause lots of
> conflicts for you and Junio. Fortunately we don't at the moment.
> 
> Nguyễn Thái Ngọc Duy (7):
>   Move try_merge_command and checkout_fast_forward to libgit.a
>   Move estimate_bisect_steps to libgit.a
>   Move print_commit_list to libgit.a
>   Move setup_diff_pager to libgit.a
>   send-pack: move core code to libgit.a
>   fetch-pack: remove global (static) configuration variable "args"
>   fetch-pack: move core code to libgit.a

This does not seem to disturb anything in pu, so I am very tempted.

I tweaked the last one, which removed the inclusion of pkt-line.h from builtin/fetch-pack.c; it is still needed by the use of packet_read_line when reading stateless rpc refs from stdin (caught by "-Wall -Werror").

-Peff