Re: [PATCH v2] fix 'make test' for HP NonStop

From: Jeff King <peff@peff.net>
Date: Oct 29, 2012, 07:06 UTC
Message-ID: <20121029070642.GD5102@sigill.intra.peff.net>
In-Reply-To: <003101cdb29f$7c8d9490$75a8bdb0$@schmitz-digital.de>

On Thu, Oct 25, 2012 at 12:57:10PM +0200, Joachim Schmitz wrote:

Show 14 quoted lines

> diff --git a/Makefile b/Makefile
> index f69979e..35380dd 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1381,6 +1381,15 @@ ifeq ($(uname_S),NONSTOP_KERNEL)
> 	MKDIR_WO_TRAILING_SLASH = YesPlease
> 	# RFE 10-120912-4693 submitted to HP NonStop development.
> 	NO_SETITIMER = UnfortunatelyYes
> +
> +	# for 'make test'
> +	# some test don't work with /bin/diff, some fail with /bin/tar
> +	# some need bash, and some need /usr/local/bin in PATH first
> +	SHELL_PATH=/usr/local/bin/bash
> +	SANE_TOOL_PATH=/usr/local/bin

I think we can drop these comments, as the reasoning really should just go in the commit message.

> +	# as of H06.25/J06.14, we might better use this
> +	#SHELL_PATH=/usr/coreutils/bin/bash
> +	#SANE_TOOL_PATH=/usr/coreutils/bin:/usr/local/bin

Is there any reason not to put both into the default SANE_TOOL_PATH? If /usr/coreutils/bin does not exist on older versions, it will be a harmless no-op. I guess we arestuck with picking one $SHELL_PATH, though.

-Peff