Re: [PATCH] Document git-svn fetch --log-window-size parameter

From

Jeff King <peff@peff.net>

Date

Oct 26, 2012, 13:32 UTC

Message-ID

<20121026133250.GI1455@sigill.intra.peff.net>

In-Reply-To

<20121026094602.GA7887@dcvr.yhbt.net>

On Fri, Oct 26, 2012 at 09:46:02AM +0000, Eric Wong wrote:

> > Thanks. Your description makes sense to me, but I do not have enough
> > git-svn knowledge to know if it covers all intended uses of the flag.
> > Eric?
> > 
> > > +--log-window-size=<n>;;
> > > +    Fetch <n> log entries per request when scanning Subversion history.
> > > +    The default is 100. For very large Subversion repositories, larger
> > > +    values may be needed for 'clone'/'fetch' to complete in reasonable
> > > +    time. But overly large values may lead to request timeouts.
> 
> Overly large values also lead to excessive memory usage.  I may have
> only had 256M in my dev machine at the time I added this parameter:

diff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt
index 64756c9..8b0d3ad 100644
--- a/Documentation/git-svn.txt
+++ b/Documentation/git-svn.txt
@@ -150,7 +150,8 @@ Skip "branches" and "tags" of first level directories;;
     Fetch <n> log entries per request when scanning Subversion history.
     The default is 100. For very large Subversion repositories, larger
     values may be needed for 'clone'/'fetch' to complete in reasonable
-    time. But overly large values may lead to request timeouts.
+    time. But overly large values may lead to higher memory usage and
+    request timeouts.
 
 'clone'::
 	Runs 'init' and 'fetch'.  It will automatically create a

?

-Peff