git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] submodule status: properly pass options with --recursive

From
Jeff King <peff@peff.net>
Date
Oct 26, 2012, 13:15 UTC
Message-ID
<20121026131507.GA2747@sigill.intra.peff.net>
In-Reply-To
<5089BB2D.90400@web.de>
On Fri, Oct 26, 2012 at 12:20:29AM +0200, Jens Lehmann wrote:
Show 8 quoted lines
> When renaming orig_args to orig_flags in 98dbe63d (submodule: only
> preserve flags across recursive status/update invocations) the call site
> of the recursive cmd_status was forgotten. At that place orig_args is
> still passed into the recursion, which is always empty now. This clears
> all options when recursing, as that variable is never set.
> 
> Fix that by renaming orig_args to orig_flags there too and add a test to
> catch that bug.

Thanks. I back-ported your patch on top of 98dbe63d so it can go to 'maint'. I'm curious, though: why didn't the test right before (which checks recursion for --cached) catch this?

-Peff
Previous: Jens LehmannNext: Phil Hord
Message 2 of 12 in “submodule status: properly pass options with --recursive”
  1. submodule status: properly pass options with --recursiveJens Lehmann, Oct 25, 2012
  2. Jeff KingOct 26, 2012
  3. Phil HordOct 26, 2012
  4. t7407: Fix recursive submodule testPhil Hord, Oct 26, 2012
  5. Jens LehmannOct 26, 2012
  6. submodule status: remove unused orig_* variablesJens Lehmann, Oct 28, 2012
  7. Jeff KingOct 29, 2012
  8. Jens LehmannOct 26, 2012
  9. 0/2 Teach --recursive to submodule syncPhil Hord, Oct 26, 2012
  10. 1/2 Teach --recursive to submodule syncPhil Hord, Oct 26, 2012
  11. 2/2 Add tests for submodule sync --recursivePhil Hord, Oct 26, 2012
  12. Jens LehmannOct 28, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.