Re: [PATCH] Fixes handling of --reference argument.

From: Jeff King <peff@peff.net>
Date: Oct 25, 2012, 08:36 UTC
Message-ID: <20121025083625.GA8390@sigill.intra.peff.net>
In-Reply-To: <5088c5a4.L25tOcUVCSwBRpYF%szager@google.com>

On Wed, Oct 24, 2012 at 09:52:52PM -0700, szager@google.com wrote:

Show 15 quoted lines

> Signed-off-by: Stefan Zager <szager@google.com>
> ---
>  git-submodule.sh |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/git-submodule.sh b/git-submodule.sh
> index ab6b110..dcceb43 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -270,7 +270,6 @@ cmd_add()
>  			;;
>  		--reference=*)
>  			reference="$1"
> -			shift
>  			;;

Is that right? We'll unconditionally do a "shift" at the end of the loop. If it were a two-part argument like "--reference foo", the extra shift would make sense, but for "--reference=*", no extra shift should be neccessary. Am I missing something?

-Peff