Re: [PATCH v3] status: refactor output format to represent "default" and add --long

From: Jeff King <peff@peff.net>
Date: Oct 18, 2012, 20:26 UTC
Message-ID: <20121018202647.GA31093@sigill.intra.peff.net>
In-Reply-To: <1350569750-26304-1-git-send-email-pclouds@gmail.com>

On Thu, Oct 18, 2012 at 09:15:50PM +0700, Nguyen Thai Ngoc Duy wrote:

Show 13 quoted lines

>  On Thu, Oct 18, 2012 at 9:03 AM, Jeff King <peff@peff.net> wrote:
>  > I think that is fine to split it like this, but you would want to update
>  > the commit message above. Probably just remove those two cases and say
>  > something like:
>  >
>  >   Note that you cannot actually trigger STATUS_FORMAT_LONG, as we do
>  >   not yet have "--long"; that will come in a follow-on patch.
>  >
>  > And then move the reasoning for how "--long" works with each case into
>  > the commit message of the next patch.
> 
>  Nope, it's hard to split the explanation in two (at least to me),
>  which may mean that the split does not make sense.

Yeah, that was the same place that I had difficulty when writing the original. This version looks OK to me.

-Peff