Re: [PATCH] notes: mention --notes in more places

From: Jeff King <peff@peff.net>
Date: Oct 17, 2012, 19:05 UTC
Message-ID: <20121017190507.GA17648@sigill.intra.peff.net>
In-Reply-To: <507EB310.8020904@redhat.com>

On Wed, Oct 17, 2012 at 07:30:56AM -0600, Eric Blake wrote:

Show 5 quoted lines

> > We've talked about it several times, but it's never happened (probably
> > because most people don't actually use notes).
> 
> And people (like me) don't use notes because they aren't documented.
> Catch-22, so we have to start somewhere.

Oh, I definitely agree your patch is the right direction. I was just explaining why it hasn't happened, even though people think it's a good idea.

Show 5 quoted lines

> I'll submit a v2 with the non-controversial edits, and spend some time
> trying to figure out how to isolate the portion of pretty-options.txt
> that is relevant to format-patch.  If it's easy enough, I can also
> consider using --- instead of Notes: as the separator when using
> format-patch.

Hmm. After digging in the archive, it seems we (including both you and me!) have discussed this several times, and there are even some patches floating around. Maybe one of them would be a good starting point for your submission (I did not read carefully over all of the arguments for each):

  Patch from Thomas, Feb 2010:

    http://thread.gmane.org/gmane.comp.version-control.git/139919/focus=140818

  Discussion between us, Dec 2010:

    http://thread.gmane.org/gmane.comp.version-control.git/163141

  Patch from Michael, Apr 2011:

    http://thread.gmane.org/gmane.comp.version-control.git/172079

-Peff