Re: [PATCH 2/2] config: treat user and xdg config permission problems as errors

From: Jeff King <peff@peff.net>
Date: Oct 14, 2012, 16:43 UTC
Message-ID: <20121014164319.GA16225@sigill.intra.peff.net>
In-Reply-To: <20121014084244.GA7190@elie.Belkin>

On Sun, Oct 14, 2012 at 01:42:44AM -0700, Jonathan Nieder wrote:

Show 16 quoted lines

> Jeff King wrote:
> 
> > For example, servers may depend on /etc/gitconfig to enforce security
> > policy (e.g., setting transfer.fsckObjects or receive.deny*). Perhaps
> > our default should be safe, and people can use GIT_CONFIG_NOSYSTEM to
> > work around a broken machine.
> 
> Very good point.  How about these patches on top?
> 
> Jonathan Nieder (2):
>   config doc: advertise GIT_CONFIG_NOSYSTEM
>   config: exit on error accessing any config file
> 
>  Documentation/git-config.txt | 8 ++++++++
>  config.c                     | 6 +++---
>  2 files changed, 11 insertions(+), 3 deletions(-)

This is my absolute favorite type of reply: the kind that you can apply with "git am".

The direction and the patches themselves look good to me. I agree with your reasoning in v2 of 3/2; it makes much more sense than v1.

Thanks.

-Peff