Re: git fails: segfault at 0 ip 00000000004076d5 sp 00007fff7806ebc0

From: Jeff King <peff@peff.net>
Date: Oct 12, 2012, 17:12 UTC
Message-ID: <20121012171256.GA21409@sigill.intra.peff.net>
In-Reply-To: <CABPQNSbRYq43rADP6BaQ_Q2SB+M76rHdX3hOSpGQk2c5UNR5hg@mail.gmail.com>

On Fri, Oct 12, 2012 at 06:34:30PM +0200, Erik Faye-Lund wrote:

Show 13 quoted lines

> > Thanks for reporting. I gave it a quick go, and the issue seems to
> > also be present in the current 'master'.
> >
> > The problem is a NULL-pointer dereferencing introduced in 8809703
> > ("http: factor out http error code handling"), where the code assume
> > that slot->results still points to http_request::results. This
> > assumption seems to be wrong.
> >
> > This seems to step around the issue, but I don't know if
> > http_request::results should be set to NULL in the first place. Jeff?
> 
> OK, it seems I jumped the gun, and Jeff already sent out a patch for
> it. Nevermind me, then :)

Independent verification is never a bad thing. :)

-Peff