git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] add basic lua infrastructure

From
Jeff King <peff@peff.net>
Date
Sep 25, 2012, 03:42 UTC
Message-ID
<20120925034211.GC3656@sigill.intra.peff.net>
In-Reply-To
<robbat2-20120925T032006-952720661Z@orbis-terrarum.net>
On Tue, Sep 25, 2012 at 03:21:10AM +0000, Robin H. Johnson wrote:
Show 7 quoted lines
> On Mon, Sep 24, 2012 at 08:25:12PM -0400,  Jeff King wrote:
> > +ifdef USE_LUA
> > +	BASIC_CFLAGS += -DUSE_LUA `pkg-config --cflags lua5.2`
> > +	EXTLIBS += `pkg-config --libs lua5.2`
> > +endif
> Can you please hoist the packagename out to a variable? It's just plain
> "lua" on Gentoo.

Yeah. I mentioned these patches were very rough, but I didn't go into detail on all the bad points. That is definitely one of them. I have no idea what the "normal" name is; my debian system sticks the version number in to allow multiple concurrent versions.

I was hoping somebody with more Lua experience could tell me what's usual. It would be nice if it just worked out of the box as soon as you said USE_LUA, but that may not be realistic.

-Peff
Previous: Robin H. JohnsonNext: Junio C Hamano
Message 7 of 15 in “git log --pretty=lua”
  1. 0/3 git log --pretty=luaJeff King, Sep 25, 2012
  2. 1/3 pretty: make some commit-parsing helpers more publicJeff King, Sep 25, 2012
  3. 2/3 add basic lua infrastructureJeff King, Sep 25, 2012
  4. Nguyen Thai Ngoc DuySep 25, 2012
  5. Jeff KingSep 25, 2012
  6. Robin H. JohnsonSep 25, 2012
  7. Jeff KingSep 25, 2012
  8. Junio C HamanoSep 25, 2012
  9. 3/3 add a "lua" pretty formatJeff King, Sep 25, 2012
  10. Jeff KingOct 6, 2012
  11. Nguyen Thai Ngoc DuySep 25, 2012
  12. Stephen BashSep 25, 2012
  13. Matthieu MoySep 25, 2012
  14. Junio C HamanoSep 25, 2012
  15. Nguyen Thai Ngoc DuySep 30, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.