Re: Quickly searching for a note

From: Jeff King <peff@peff.net>
Date: Sep 25, 2012, 00:42 UTC
Message-ID: <20120925004223.GC19586@sigill.intra.peff.net>
In-Reply-To: <505F2598.7080704@drmicha.warpmail.net>

On Sun, Sep 23, 2012 at 05:07:04PM +0200, Michael J Gruber wrote:

Show 10 quoted lines

> > If we linked with an embeddable scripting language interpreter
> > (e.g. lua, tcl, guile, ...), it may be a more practical enhancement,
> > though.
> > 
> 
> Yes, the idea is "extend, don't embed" the other way round, so to say. I
> still think extending "git log" so that it can call a script with commit
> info already in the environment gives a more convenient approach then
> "embedding git rev-list" into your own script. It's not more performant,
> of course.

I think Junio is going the other way than you think. That is, you still run rev-list, but rather than call a sub-program, you call a snippet of an embeddable script. Which is the same idea as yours, but theoretically way faster.

> I just see many more requests of the type "grep notes" coming, i.e.
> limitting based on other commit info, or in a different way then already
> possible. Just image you want to find out who's responsible for those
> commits in git.git with subject lengths > 100 ;)

Like this:

  git log --lua-filter='return subject().len > 100'

? :)

-Peff