Re: {bug} warning: unable to access 'RelNotes/.gitattributes'

From: Jeff King <peff@peff.net>
Date: Sep 13, 2012, 12:37 UTC
Message-ID: <20120913123740.GB4287@sigill.intra.peff.net>
In-Reply-To: <7vpq5qa0w9.fsf@alter.siamese.dyndns.org>

On Wed, Sep 12, 2012 at 11:32:22PM -0700, Junio C Hamano wrote:

Show 5 quoted lines

> "git repack" started giving the above warning, and I am guessing
> that the recent 11e50b2 (attr: warn on inaccessible attribute files,
> 2012-08-21) exposed a bug where we ask stat(2) not lstat(2) by
> mistake before deciding to append .gitattributes to see if that
> directory has a per-directory attributes file.

Interesting. I don't get any such warning on repack. And RelNotes points to a file, so I'm not sure why stat() would make us think it was a dir.

> We simply used to notice and ignore any failure from open() and moved
> on, but we started distinguishing between ENOENT and others (in this
> case, we get ENOTDIR), and added a warning for non-ENOENT cases and I
> think that is what I am seeing.

I can provoke such a warning by doing:

  git check-attr -a RelNotes/foo

I haven't decided whether that's a good or bad thing. It makes sense, since the file you are asking for would get ENOTDIR, but maybe somebody is feeding junk to check-attr.

-Peff