Re: [PATCH] Makefile: quiet shell commands when "make --silent"

From: Pete Wyckoff <pw@padd.com>
Date: Sep 10, 2012, 12:16 UTC
Message-ID: <20120910121651.GA26218@padd.com>
In-Reply-To: <7voblepvdv.fsf@alter.siamese.dyndns.org>

gitster@pobox.com wrote on Sun, 09 Sep 2012 17:35 -0700:

Show 8 quoted lines

> Pete Wyckoff <pw@padd.com> writes:
> 
> > Option "--silent", "--quiet" or "-s" to make prevents
> > echoing of commands as they are executed.  However, there
> > are some explicit "echo" commands in the Makefile and in
> > the two GIT-VERSION-GEN scripts that always echo.
> 
> "make -s clean"?

Fixed here.

Show 5 quoted lines

> I am not very enthused, especially if the primary motivation is
> about "check-docs".  Such a script must be prepared to filter out
> cruft from the output of $(MAKE) and to pick out the bits that
> interests it and that has been the way of life with $(MAKE) way
> before Git started as a project ;-).

My motivation was to quiet output from a script I use to test bisectability. I sent it out because I noticed someone else found the verbosity annoying too.

Agreed that "fixing" check-docs is not important; that's why I didn't bother in this patch.

		-- Pete