Re: read-cache-v5.c: compiler warnings

From: Thomas Gummerer <t.gummerer@gmail.com>
Date: Aug 20, 2012, 08:29 UTC
Message-ID: <20120820082854.GA10909@tommy-fedora>
In-Reply-To: <50313AEC.1060700@ramsay1.demon.co.uk>

On 08/19, Ramsay Jones wrote:

Show 15 quoted lines

> Hi Thomas,
> 
> Just an FYI; two out of the three gcc compilers I use (Linux, cygwin
> but not MingW), issue the following warnings:
> 
>         CC read-cache-v5.o
>     read-cache-v5.c: In function `write_index_v5':
>     read-cache-v5.c:1011: warning: 'dir' might be used uninitialized in this function
>     read-cache-v5.c:1012: warning: 'search' might be used uninitialized in this function
>     read-cache-v5.c:1012: warning: 'found' might be used uninitialized in this function
> 
> [commit d2537158 ("Write index-v5", 16-08-2012)]
> 
> Normally I would take a look and offer a patch, but I haven't found time
> to do so in the last 10 days. So, I'm just giving you a heads up ... ;-P

Thanks for noticing. This warnings only seem to be issued by older versions of gcc, which is probably why two compilers give the warnings while one doesn't.

The variables can never be uninitialized, because they are guarded by ifs and older versions don't seem to recognize that. I'll fix them in a re-roll though (or a separate patch if that's preferred), just waiting for some feedback for v4 of my series.

Show 6 quoted lines

> 
> HTH
> 
> ATB,
> Ramsay Jones
>

Thomas