Re: [PATCH] gitweb: Add support for gravatar-ssl
- From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
- Date
- Aug 9, 2012, 19:36 UTC
- Message-ID
- <20120809193655.7418D13F8069@mailgw.unict.it>
- In-Reply-To
- <20120809184210.GA27795@goeswhere.com>
Chris West (Faux) wrote:
Show 7 quoted lines
> Teach gitweb to allow 'avatar' to be set to 'gravatar-ssl', switching > to the https://secure.gravatar.com url form, to avoid mixed content > warnings when serving gitweb over https, with gravatar enabled. > --- > I'd alternatively propose always using the https:// form of the URL, > but it seems significantly slower, so it's probably best to let people > pick to continue using the insecure version.
Rather than introducing a new, separate setting, wouldn't it be better to have the gravatar URL be automatically decided based on the current gitweb URL? (use the ssl gravar url when the current protocol is https, and the standard http url otherwise)