Re: [PATCH/RFC] git svn: handle errors and concurrent commits in dcommit

From: Eric Wong <normalperson@yhbt.net>
Date: Aug 8, 2012, 23:07 UTC
Message-ID: <20120808230754.GB24956@dcvr.yhbt.net>
In-Reply-To: <5021F9D4.1010700@debian.org>

Robert Luberda <robert@debian.org> wrote:

Show 10 quoted lines

> Eric Wong wrote:
> >> +		echo "PATH=\"$PATH\"; export PATH" >> $hook
> >> +		echo "svnconf=\"$svnconf\"" >> $hook
> >> +		cat >> "$hook" <<- 'EOF2'
> >> +			cd work-auto-commits.svn
> >> +			svn up --config-dir "$svnconf"
> > 
> > That doesn't seem to interact well with users who depend on
> > svn_cmd pointing to something non-standard.  Not sure
> > what to do about it, though....

> I have no idea how to change it either. I've tried to source the
> lib-git-svn.sh file inside the hook, but it sources test-lib.sh, and the
> latter script doesn't work well if it is sourced by non-test script.
> Anyway I the part of my original patch unchanged.

Ah, so svn_cmd only cares about --config-dir and you already handled that :) I misremembered it also allowed for non-standard SVN installations :x

I've pushed your updated patch to my "maint" branch on git://bogomips.org/git-svn since "master" has larger pending changes.

Thanks!