git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Improve tests for detached worktree in git-submodule

From
Jeff King <peff@peff.net>
Date
Jul 30, 2012, 16:39 UTC
Message-ID
<20120730163907.GA18109@sigill.intra.peff.net>
In-Reply-To
<1343664610-479-1-git-send-email-dangra@gmail.com>
On Mon, Jul 30, 2012 at 01:10:10PM -0300, Daniel Graña wrote:
> Subject: Re: [PATCH] Improve tests for detached worktree in git-submodule
> 
> Signed-off-by: Daniel Graña <dangra@gmail.com>

The space between the subject and your S-o-b is an excellent place to explain the rationale for your commit.

How are we improving them? What cases or classes of failure does this catch that the original did not? It may be because I have not been following this topic closely, but reading the patch, I am not sure what the purpose is. Please make life easier for reviewers by telling us what to expect and why before we even get to the patch.

-Peff
Previous: Daniel GrañaNext: Junio C Hamano
Message 2 of 12 in “Improve tests for detached worktree in git-submodule”
  1. Improve tests for detached worktree in git-submoduleDaniel Graña, Jul 30, 2012
  2. Jeff KingJul 30, 2012
  3. Junio C HamanoJul 30, 2012
  4. Daniel GrañaJul 30, 2012
  5. Junio C HamanoJul 30, 2012
  6. Junio C HamanoJul 30, 2012
  7. Improve tests for detached worktree in git-submoduleDaniel Graña, Jul 30, 2012
  8. Junio C HamanoJul 30, 2012
  9. Daniel GrañaJul 30, 2012
  10. Improve tests for detached worktree in git-submoduleDaniel Graña, Jul 30, 2012
  11. Daniel GrañaJul 30, 2012
  12. Fwd: [PATCH] Improve tests for detached worktree in git-submoduleDaniel Graña, Jul 30, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.